[QUIC] Remove check for AzL3 for QUIC and H/3 tests by ManickaP · Pull Request #126834 · dotnet/runtime

ManickaP · 2026-04-13T13:42:11Z

SymCrypt 1.9.5 is out, docker images are already fixed, let's see if the base VM images are up-to-date or need re-building.

dotnet-policy-service · 2026-04-13T13:43:33Z

Tagging subscribers to this area: @karelz, @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

Copilot

Pull request overview

This PR removes the Azure Linux 3 VM-specific test gating that was added due to MsQuic failures, with the intent of re-enabling QUIC and HTTP/3 test execution now that SymCrypt images are expected to be updated.

Changes:

Remove IsNotAzureLinux3VM conditions from System.Net.Quic functional test classes.
Remove the IsNotAzureLinux3VM check from HttpClientHandlerTestBase.IsHttp3Supported.
Delete the IsNotAzureLinux3VM helper properties that implemented the AzL3 skip logic.

Reviewed changes

Copilot reviewed 10 out of 10 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
src/libraries/System.Net.Quic/tests/FunctionalTests/QuicTestBase.cs	Removes the `IsNotAzureLinux3VM` helper used to skip AzL3 VMs.
src/libraries/System.Net.Quic/tests/FunctionalTests/QuicStreamTests.cs	Drops AzL3 from the `ConditionalClass` gating list.
src/libraries/System.Net.Quic/tests/FunctionalTests/QuicStreamConnectedStreamConformanceTests.cs	Drops AzL3 from the `ConditionalClass` gating list.
src/libraries/System.Net.Quic/tests/FunctionalTests/QuicListenerTests.cs	Drops AzL3 from the `ConditionalClass` gating list.
src/libraries/System.Net.Quic/tests/FunctionalTests/QuicConnectionTests.cs	Drops AzL3 from the `ConditionalClass` gating list.
src/libraries/System.Net.Quic/tests/FunctionalTests/MsQuicTests.cs	Drops AzL3 from the `ConditionalClass` gating list.
src/libraries/System.Net.Quic/tests/FunctionalTests/MsQuicRemoteExecutorTests.cs	Drops AzL3 from the `ConditionalClass` gating list.
src/libraries/System.Net.Quic/tests/FunctionalTests/MsQuicPlatformDetectionTests.cs	Attempts to remove AzL3 gating, but introduces an invalid `ConditionalClass` usage (see comment).
src/libraries/System.Net.Quic/tests/FunctionalTests/MsQuicCipherSuitesPolicyTests.cs	Drops AzL3 from the `ConditionalClass` gating list.
src/libraries/System.Net.Http/tests/FunctionalTests/HttpClientHandlerTestBase.SocketsHttpHandler.cs	Removes the AzL3 gating from HTTP/3 support detection and deletes the helper property.

ManickaP · 2026-04-15T11:26:07Z

/azp list

azure-pipelines · 2026-04-15T11:26:14Z

CI/CD Pipelines for this repository: runtime-coreclr outerloop runtime-coreclr jitstress runtime-coreclr jitstressregs runtime-coreclr jitstress2-jitstressregs runtime-coreclr gcstress0x3-gcstress0xc runtime-coreclr gcstress-extra runtime-coreclr r2r-extra runtime-coreclr jitstress-isas-x86 runtime-coreclr jitstress-isas-arm runtime-coreclr jitstressregs-x86 runtime-coreclr libraries-jitstressregs runtime-coreclr libraries-jitstress2-jitstressregs runtime-coreclr r2r runtime-coreclr runincontext runtime-coreclr crossgen2 runtime-libraries-coreclr outerloop runtime-libraries-coreclr outerloop-windows runtime-libraries-coreclr outerloop-linux runtime-libraries-coreclr outerloop-osx runtime runtime-libraries enterprise-linux runtime-libraries stress-http runtime-libraries stress-ssl runtime-dev-innerloop runtime-coreclr crossgen2 outerloop coreclr-release-outerloop-nightly runtime-coreclr crossgen2-composite runtime-jit-experimental runtime-coreclr libraries-jitstress dotnet-linker-tests runtime-coreclr ilasm runtime-coreclr crossgen2-composite gcstress runtime-coreclr pgo runtime-coreclr libraries-pgo Antigen runtime-community Fuzzlyn runtime-coreclr superpmi-replay runtime-wasm runtime-coreclr superpmi-diffs runtime-coreclr superpmi-asmdiffs-checked-release runtime-extra-platforms jit-cfg runtime-wasm-perf runtime-llvm runtime-coreclr jitstress-random runtime-coreclr libraries-jitstress-random runtime-wasm-non-libtests runtime-android runtime-androidemulator runtime-ioslike runtime-ioslikesimulator runtime-linuxbionic runtime-maccatalyst runtime-coreclr pgostress runtime-coreclr jitstress-isas-avx512 runtime-libraries-mono outerloop runtime-sanitized runtime-wasm-dbgtests runtime-wasm-optional runtime-nativeaot-outerloop runtime-coreclr superpmi-collect-test runtime-diagnostics runtime-interpreter runtime-report-green runtime-coreclr hardware-intrinsics runtime-libraries-interpreter runtime-vmr-validation runtime-libraries stress-http-pr runtime-libraries stress-ssl-pr

ManickaP · 2026-04-15T11:28:00Z

/azp run runtime

azure-pipelines · 2026-04-15T11:28:28Z

Azure Pipelines successfully started running 1 pipeline(s).

ManickaP · 2026-04-15T11:28:36Z

/azp run runtime-libraries-coreclr outerloop

azure-pipelines · 2026-04-15T11:28:47Z

Azure Pipelines successfully started running 1 pipeline(s).

ManickaP · 2026-04-16T10:26:52Z

This is still failing, the bare VMs have not been updated yet. I'm asking around in FR channel. I'll keep this opne for now, hopefully it won't take long to get updates in the images.

wfurt · 2026-04-16T16:00:36Z

that is curious. The images were rebuilt last week. I don't see Quic failures above.

ManickaP · 2026-04-16T16:43:56Z

that is curious. The images were rebuilt last week. I don't see Quic failures above.

Because we don't normally run our tests on "naked" VM (sometimes we do, but I don't fully understand the heuristics), but outerloop does: https://dev.azure.com/dnceng-public/public/_build/results?buildId=1380018&view=ms.vss-test-web.build-test-results-tab, and it's still failing: https://helixr1107v0xdcypoyl9e7f.blob.core.windows.net/dotnet-runtime-refs-pull-126834-merge-2f014b2698b447beb9/System.Net.Quic.Functional.Tests/3/console.8b9de10c.log?helixlogtype=result

And FR are on it, we figured out that it should be rebuilt and packages updated, but somehow they aren't... So it's being investigated.

ManickaP · 2026-04-23T08:25:57Z

/azp run runtime-libraries-coreclr outerloop

ManickaP · 2026-04-23T08:26:10Z

/azp run runtime

azure-pipelines · 2026-04-23T08:26:14Z

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines · 2026-04-23T08:26:33Z

Azure Pipelines successfully started running 1 pipeline(s).

ManickaP · 2026-04-23T13:28:51Z

/azp run runtime-libraries-coreclr outerloop

azure-pipelines · 2026-04-23T13:29:07Z

Azure Pipelines successfully started running 1 pipeline(s).

ManickaP · 2026-04-24T08:54:13Z

It's running now:

Console log: 'System.Net.Quic.Functional.Tests' from job 25aff52c-3400-4111-b153-178f1b7918b6 workitem 7b4f8783-25e9-415d-b4b8-dca71a1aef1b (azurelinux.3.amd64.open.rt) executed on machine a00DVDJ running Linux-6.6.130.1-3.azl3-x86_64-with-glibc2.38
...
  Discovering: System.Net.Quic.Functional.Tests (method display = ClassAndMethod, method display options = None)
  Discovered:  System.Net.Quic.Functional.Tests (found 8 of 153 test cases)
  Starting:    System.Net.Quic.Functional.Tests (parallel test collections = on [2 threads], stop on fail = off)
MsQuic supported and using 'libmsquic.so 2.5.7.144496271 (801b0e958f3e33e9998766c3371c1ca348254650)' (OpenSSL).
MsQuic Counters:
    CONN_CREATED 3608
    CONN_HANDSHAKE_FAIL 1231
    CONN_APP_REJECT 1226
    CONN_LOAD_REJECT 0

Unobserved exceptions of 0 different types: 

  Finished:    System.Net.Quic.Functional.Tests
=== TEST EXECUTION SUMMARY ===
   System.Net.Quic.Functional.Tests  Total: 30, Errors: 0, Failed: 0, Skipped: 0, Time: 54.194s

https://helixr1107v0xdcypoyl9e7f.blob.core.windows.net/dotnet-runtime-refs-pull-126834-merge-25aff52c34004111b1/System.Net.Quic.Functional.Tests/1/console.d4105419.log?helixlogtype=result
https://helixr1107v0xdcypoyl9e7f.blob.core.windows.net/dotnet-runtime-refs-pull-126834-merge-614d7c181bbf4ece8b/System.Net.Quic.Functional.Tests/1/console.e8ce2d0b.log?helixlogtype=result

ManickaP · 2026-04-24T08:54:23Z

/ba-g unrelated

Remove check for AzL3 for QUIC and H/3 tests

7093abc

Copilot AI review requested due to automatic review settings April 13, 2026 13:42

github-actions Bot added the area-System.Net.Quic label Apr 13, 2026

dotnet-policy-service Bot assigned ManickaP Apr 13, 2026

Copilot started reviewing on behalf of ManickaP April 13, 2026 13:43 View session

Copilot AI reviewed Apr 13, 2026

View reviewed changes

Comment thread src/libraries/System.Net.Quic/tests/FunctionalTests/MsQuicPlatformDetectionTests.cs

wfurt approved these changes Apr 13, 2026

View reviewed changes

build-analysis Bot mentioned this pull request Apr 15, 2026

"We stopped hearing from agent Azure Pipelines 32. Verify the agent machine is running and has a healthy network connection" dotnet/dnceng#1886

Open

3 tasks

build-analysis Bot mentioned this pull request Apr 23, 2026

browser-wasm linux Release LibraryTests queues timing out #117974

Open

ManickaP merged commit a5840f3 into dotnet:main Apr 24, 2026
89 of 107 checks passed

dotnet-maestro Bot mentioned this pull request Apr 25, 2026

[main] Source code updates from dotnet/runtime dotnet/dotnet#6272

Merged

Conversation

ManickaP commented Apr 13, 2026

Uh oh!

dotnet-policy-service Bot commented Apr 13, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

ManickaP commented Apr 15, 2026

Uh oh!

azure-pipelines Bot commented Apr 15, 2026

Uh oh!

ManickaP commented Apr 15, 2026

Uh oh!

azure-pipelines Bot commented Apr 15, 2026

Uh oh!

ManickaP commented Apr 15, 2026

Uh oh!

azure-pipelines Bot commented Apr 15, 2026

Uh oh!

ManickaP commented Apr 16, 2026

Uh oh!

wfurt commented Apr 16, 2026

Uh oh!

ManickaP commented Apr 16, 2026

Uh oh!

ManickaP commented Apr 23, 2026

Uh oh!

ManickaP commented Apr 23, 2026

Uh oh!

azure-pipelines Bot commented Apr 23, 2026

Uh oh!

azure-pipelines Bot commented Apr 23, 2026

Uh oh!

ManickaP commented Apr 23, 2026

Uh oh!

azure-pipelines Bot commented Apr 23, 2026

Uh oh!

ManickaP commented Apr 24, 2026

Uh oh!

ManickaP commented Apr 24, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants